Skip to content

C++: Document the three predicates for array size#180

Merged
dave-bartolomeo merged 2 commits into
github:masterfrom
jbj:ArrayType-size-docs
Sep 11, 2018
Merged

C++: Document the three predicates for array size#180
dave-bartolomeo merged 2 commits into
github:masterfrom
jbj:ArrayType-size-docs

Conversation

@jbj

@jbj jbj commented Sep 11, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@jbj jbj added the C++ label Sep 11, 2018
Comment thread cpp/ql/src/semmle/code/cpp/Type.qll Outdated

/**
* Gets the byte size of this array. Only has a result for arrays declared to be of a constant
* size. This predicate is a synonym for `getByteSize`. See `getArraySize` for getting the number

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for getSize.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I removed the sentence because I don't think people should use getSize directly on an ArrayType.

@dave-bartolomeo dave-bartolomeo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-bartolomeo dave-bartolomeo merged commit 49b8db9 into github:master Sep 11, 2018
smowton pushed a commit to smowton/codeql that referenced this pull request Jan 17, 2022
…-extraction

Extract externally defined inner classes only once
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
…tion-follow-up

PS: Fix PowerShell dataflow/taint-tracking failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants